Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tracks from more than one artists in Zune Shell. #216

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

amaid
Copy link
Collaborator

@amaid amaid commented Aug 12, 2022

// TODO

This is currently blocked because we are currently missing:

  • Ability to share AppSettings with the shells, which is needed to build MergedCoreConfig object.
  • Ability to perform playback operation on a custom MergedTrackCollection, the plugins provided by the app don't get applied automatically.

Overview

Closes #0

Checklist

This PR meets the following requirements:

  • Tested and contains NO breaking changes or known regressions.
  • Tested with the upstream branch merged in.
  • Tests have been added for bug fixes / features (or this option is not applicable)
  • All new code has been documented (or this option is not applicable)
  • Headers have been added to all new source files (or this option is not applicable)

Additional info

Not provided

@amaid
Copy link
Collaborator Author

amaid commented Aug 14, 2022

Updated the description with the blockers

@Arlodotexe

@Arlodotexe
Copy link
Owner

Arlodotexe commented Apr 26, 2023

Previously blocked by

  1. Ability to share AppSettings with the shells, which is needed to build MergedCoreConfig object.
  2. Ability to perform playback operation on a custom MergedTrackCollection, the plugins provided by the app don't get applied automatically.
  1. Is unblocked. You can access this via the dataroot passed into your shell - IStrixDataRoot.MergeConfig.
  2. Partially unblocked by [improvement] View models implement IDelegatable #245. This will allow us to access the StrixDataRootPluginWrapper, but we forgot to expose the constructor-provided plugins as a property.

Let's finish 2 separately in #280, so it shows in the changelog properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants