Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .metainfo.xml for AppStream files #1224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JakobDev
Copy link

@JakobDev JakobDev commented Dec 8, 2022

.metainfo.xml is the file extension that should be used for AppStream files. .appdata.xml is deprecated. Building with the old .appdata.xml extension will still work, but print a deprecated message. Fixes AppImage/appimagetool#77.

@probonopd
Copy link
Member

Thanks @JakobDev.

If we allow this here, we'd also need to take care of this in all consumers of AppImages that make use of AppStream, such as https://github.com/AppImage/appimage.github.io/...

@JakobDev
Copy link
Author

JakobDev commented Dec 9, 2022

@probonopd

I have now created a PR for appimage.github.io

@JakobDev
Copy link
Author

JakobDev commented Dec 9, 2022

btw:
I think we should remove the appstream-util check. It is really outdated. appstreamcli is the reference implementation. appstream.util sometimes reports files that are valid as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppStream metadata is not found if named %{id}.metainfo.xml
2 participants