Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine container #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Alpine container #8

wants to merge 9 commits into from

Conversation

Ansuel
Copy link
Owner

@Ansuel Ansuel commented Jan 11, 2023

Thanks for your contribution to OpenWrt!

To help keep the codebase consistent and readable,
and to help people review your contribution,
we ask you to follow the rules you find in the wiki at this link
https://openwrt.org/submitting-patches

Please remove this message before posting the pull request.

Package external toolchain after correct build.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Add option to configure container to use for build and build-tools test.
By default the tools and buildbot container is used if no option is
provided.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Build and push container with external toolchain embedded in the
container image.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Use alpine container as base image for everything.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Add support to use container included external toolchain and skip
redownloading external sdk for each test.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Backport patch fixing compile on musl libc to improve support for alpine
image.

Ref: https://sourceware.org/bugzilla/show_bug.cgi?id=29477
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Alone7z fails with error

cc      -O2 -c -Wall -Werror -Wextra  -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fPIC  -o _o/CpuArch.o ../../../../C/CpuArch.c
cc      -O2 -c -Wall -Werror -Wextra  -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fPIC  -o _o/Delta.o ../../../../C/Delta.c
cc      -O2 -c -Wall -Werror -Wextra  -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fPIC  -o _o/LzFind.o ../../../../C/LzFind.c
cc      -O2 -c -Wall -Werror -Wextra  -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fPIC  -o _o/Lzma2Dec.o ../../../../C/Lzma2Dec.c
cc      -O2 -c -Wall -Werror -Wextra  -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fPIC  -o _o/Lzma2DecMt.o ../../../../C/Lzma2DecMt.c
In file included from ../../../../C/MtDec.h:10,
                 from ../../../../C/Lzma2DecMt.c:30:
../../../../C/Threads.h:80:9: error: unknown type name 'cpu_set_t'
   80 | typedef cpu_set_t CCpuSet;
      |         ^~~~~~~~~
make[3]: *** [../../7zip_gcc.mak:1118: _o/Lzma2DecMt.o] Error 1
make[3]: Leaving directory '/__w/openwrt/openwrt/openwrt/build_dir/host/7z-22.01/CPP/7zip/Bundles/Alone7z'

It seems -D_GNU_SOURCE is needed for cpu_set_t type to correctly work
with musl libc.
Also we need to use a portable variant of pthread_setaffinity that can
work with both glibc and musl libc.

Add the 2 required patch to make 7zip correctly compile with musl libc.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Add concurrency limits for pull request test so that on pull request
refresh old jobs are cancelled.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
@Ansuel Ansuel force-pushed the master branch 6 times, most recently from 118b46f to a575158 Compare June 16, 2024 16:15
@Ansuel Ansuel force-pushed the master branch 4 times, most recently from 12b0c50 to e5cf548 Compare July 4, 2024 14:06
Ansuel pushed a commit that referenced this pull request Jul 5, 2024
@Ansuel Ansuel force-pushed the master branch 2 times, most recently from e73fda1 to b3e7969 Compare August 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant