Skip to content

Commit

Permalink
build: fix including busybox, procd and apk/opkg in imagebuilder
Browse files Browse the repository at this point in the history
Since the image builder pulls package lists from metadata directly,
add procd and busybox as depdendencies to base-files.
As for the package manager itself, since it can be disabled it needs
to be added directly in the image builder makefile

Fixes: 44598c2 ("build: remove broken dependency of metadata on toplevel .config variables")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
  • Loading branch information
nbd168 committed Nov 13, 2024
1 parent f841870 commit 4c65359
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
6 changes: 5 additions & 1 deletion package/base-files/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ endif
define Package/base-files
SECTION:=base
CATEGORY:=Base system
DEPENDS:=+netifd +libc +jsonfilter +SIGNED_PACKAGES:usign +SIGNED_PACKAGES:openwrt-keyring +NAND_SUPPORT:ubi-utils +fstools +fwtool
DEPENDS:= \
+netifd +libc +jsonfilter +SIGNED_PACKAGES:usign +SIGNED_PACKAGES:openwrt-keyring \
+NAND_SUPPORT:ubi-utils +fstools +fwtool \
+SELINUX:procd-selinux +!SELINUX:procd +SECCOMP:procd-seccomp \
+SELINUX:busybox-selinux +!SELINUX:busybox
TITLE:=Base filesystem for OpenWrt
URL:=http://openwrt.org/
VERSION:=$(PKG_RELEASE)~$(lastword $(subst -, ,$(REVISION)))
Expand Down
3 changes: 0 additions & 3 deletions package/system/procd/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ define Package/procd
$(call Package/procd/Default)
VARIANT:=default
CONFLICTS:=procd-selinux
DEFAULT:=y if !SELINUX
endef

define Package/procd-selinux
Expand All @@ -59,7 +58,6 @@ define Package/procd-selinux
TITLE += with SELinux support
PROVIDES:=procd
VARIANT:=selinux
DEFAULT:=y if SELINUX
endef

define Package/procd-ujail
Expand All @@ -75,7 +73,6 @@ define Package/procd-seccomp
CATEGORY:=Base system
DEPENDS:=@SECCOMP +libubox +libblobmsg-json
TITLE:=OpenWrt process seccomp helper + utrace
DEFAULT:=y if SECCOMP
endef

define Package/uxc
Expand Down
2 changes: 0 additions & 2 deletions package/utils/busybox/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ define Package/busybox
$(call Package/busybox/Default)
CONFLICTS:=busybox-selinux
VARIANT:=default
DEFAULT:=y if !SELINUX
endef

define Package/busybox-selinux
Expand All @@ -65,7 +64,6 @@ define Package/busybox-selinux
DEPENDS += +libselinux
VARIANT:=selinux
PROVIDES:=busybox
DEFAULT:=y if SELINUX
endef

define Package/busybox/description
Expand Down
5 changes: 5 additions & 0 deletions target/imagebuilder/files/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,11 @@ _call_info: FORCE
echo 'Available Profiles:'
echo; $(PROFILE_LIST)

ifneq ($(CONFIG_USE_APK),)
DEFAULT_PACKAGES += apk-mbedtls
else
DEFAULT_PACKAGES += opkg
endif
BUILD_PACKAGES:=$(sort $(DEFAULT_PACKAGES) $($(USER_PROFILE)_PACKAGES) kernel)
# "-pkgname" in the package list means remove "pkgname" from the package list
BUILD_PACKAGES:=$(filter-out $(filter -%,$(BUILD_PACKAGES)) $(patsubst -%,%,$(filter -%,$(BUILD_PACKAGES))),$(BUILD_PACKAGES))
Expand Down

0 comments on commit 4c65359

Please sign in to comment.