DON'T BE GREEDY regular expression fix .. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression (that I wrote) on line 230 was too greedy. If the U modifier is used then this is ungreedy by default. The problem is when you have the question mark behind a quantifier then it will inverse that quantifier's greediness. So it will search for an iframe open tag, then search for the last iframe close tag (rather than the next iframe close tag). ** ORIGINAL REGEXP ** |<iframe\s+.*?</iframe>|siU By removing the question mark, the whole expression is not greedy by default, resulting in functionality just like you'd want. ** FIXED REGEXP ** |<iframe\s+.*</iframe>|siU
|
oh my .. it removed the code I wrote .. oh well.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression (that I wrote) on line 230 was too greedy.
If the U modifier is used then this is ungreedy by default.
The problem is when you have the question mark behind a quantifier then it will inverse that quantifier's greediness.
So it will search for an iframe open tag, then search for the last iframe close tag (rather than the next iframe close tag).
* ORIGINAL REGEXP **
|<iframe\s+.?</iframe>|siU
By removing the question mark, the whole expression is not greedy by default, resulting in functionality just like you'd want.
* FIXED REGEXP **
|<iframe\s+.</iframe>|siU