Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Save trial group as question key in results #903

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

drikusroor
Copy link
Contributor

This pull request adds validity checks for experiment sections in the CongoSameDiff class. It ensures that all sections have a group value and at least one section has the tag "practice". Additionally, it includes the following commits:

  • feat: Include group in trial key to be able to distinguish them
  • feat: Add validity checks for experiment sections in CongoSameDiff class

Resolves #901

@drikusroor drikusroor changed the title Added: Add validity checks for experiment sections in CongoSameDiff class Added: Save trial group as question key in results Mar 28, 2024
@drikusroor drikusroor self-assigned this Mar 28, 2024
Copy link
Collaborator

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good idea to make the assumptions about the playlist that goes with an experiment explicit. I wonder if we can generalize this idea to improve the stability of other experiments, too.

@drikusroor drikusroor force-pushed the iterate/900-csd-store-results branch from f83fabb to b510ad4 Compare April 2, 2024 09:52
@drikusroor drikusroor merged commit 137bfaa into develop Apr 2, 2024
10 checks passed
@drikusroor drikusroor deleted the iterate/900-csd-store-results branch April 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Same-diff] make sure the practice trial data and main experiment data are recorded accordingly
2 participants