fix: use random seed before shuffle #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evert-R
approved these changes
Mar 27, 2024
|
Would be nice if there had been a test that runs that randomisation method a couple of times to see if it stays in the same random order |
drikusroor
reviewed
Mar 27, 2024
| if self.randomize: | ||
| random.shuffle(pairs) | ||
| random.seed(self.random_seed) | ||
| random.shuffle(pairs) | ||
| selected_pairs = pairs[:self.num_pairs] | ||
| originals = session.playlist.section_set.filter( |
There was a problem hiding this comment.
Is this actually going to work? There is randomisation going on, but then you do a query from the database with a filter on the selected pairs. Won't that just return the sections in the order as returned from the database?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address problem for Congo-MatchingPairs that the board used for the practice sessions should be fixed, but not too predictable.