Hotfix: Fix prepare_result function calls and add type hints (#701) #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix: Fix prepare_result function calls in listening_conditions.py by adding key parameter * fix: Fix Trial instantiation in ListeningConditions (second parameter is html, see trial.py) * refactor: Add type hints to prepare_result function * refactor: Include type hints to Trial class constructor * Add test cases for ListeningConditions class * fix(lint): Fix formatting in trial.py and remove unnecessary lines in test_listening_conditions.py (cherry picked from commit 6f52358)
drikusroor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Fix prepare_result function calls in listening_conditions.py by adding key parameter
fix: Fix Trial instantiation in ListeningConditions (second parameter is html, see trial.py)
refactor: Add type hints to prepare_result function
refactor: Include type hints to Trial class constructor
Add test cases for ListeningConditions class
fix(lint): Fix formatting in trial.py and remove unnecessary lines in test_listening_conditions.py
(cherry picked from commit 6f52358)
Resolves #736