Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buffers object to check wether a section has already been loaded #1403

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Evert-R
Copy link
Contributor

@Evert-R Evert-R commented Nov 26, 2024

This PR fixes the bug that occurs when you play matching_pairs_lite for the second time (via the dashboard) with 8 originals.

When the sections are loaded the buffer list gets cleared before loading the first section.
we used previousSource to determine wether a section had already been loaded.
A section might still be loaded, but if it isn't added to the buffers object, it will not be passed on to matching pairs.

I now changed this it to checking the buffers object to check if a section has been loaded.

Fixes: #1368

Copy link
Collaborator

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed IRL, make sure this change doesn't introduce a loading time in Hooked experiments, for which the check against previousSource was introduced. Perhaps the store slice for actions added per #1397 can be the basis of a more robust solution.

@Evert-R
Copy link
Contributor Author

Evert-R commented Nov 26, 2024

As discussed IRL, make sure this change doesn't introduce a loading time in Hooked experiments, for which the check against previousSource was introduced. Perhaps the store slice for actions added per #1397 can be the basis of a more robust solution.

I made some changes for previously loaded single section requests.

@Evert-R Evert-R merged commit 1504e5f into develop Nov 26, 2024
11 checks passed
@Evert-R Evert-R deleted the bugfix-er/matching-pairs-missing-sections branch November 26, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - ONE PAIR BEING SILENT on original board of Matching Pairs Congo version
2 participants