Style: Improve styling & stories of profile view, rank & cup #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikusroor
commented
Oct 2, 2024
drikusroor
commented
Oct 2, 2024
BeritJanssen
approved these changes
Oct 31, 2024
drikusroor
force-pushed
the
refactor/profile
branch
from
d758a3e
to
8573e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the code of the
Profilepage component and theProfileViewcould be improved upon. I've also expanded on its story, adding more possible scenarios. When I was working on that, I also noticed the styling was a bit off. I subsequently found out some things that could also be improved inRank/Cup, which I did. See the screenshots below for comparison.Additionally, I updated the routes a bit, removing the
exactprop, which doesn't exist anymore inreact-routerv6, and by removing the non-existent route for "session".Screenshots
Profile view
Before
After