Added: Disable pinch zoom on iOS #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new hook called useDisableIOSPinchZoomOnTouchDevices to the frontend codebase. The hook is responsible for preventing pinch zoom gestures on iOS devices. It is used in the App component to disable pinch zoom on touch devices.
drikusroor
force-pushed
the
refactor/disable-pinch-zoom
branch
from
bd55b3d
to
8ef253d
Compare
BeritJanssen
approved these changes
Sep 24, 2024
Same, I will have to test this on my phone on staging 😅 |
drikusroor
added a commit
that referenced
this pull request
Nov 5, 2024
* fix: correct video links * fix: Refactor Docker commands in scripts (#1282) Update the Docker commands in the scripts to use the "docker compose" syntax instead of "docker-compose". * fix: Fix some search & replace too many, where I mistook `docker-compose-deploy.yml` for a `docker-compose` command (#1283) * fix(style): Prevent percentage circle from overlapping background circle (#1281) * Added: Disable pinch zoom on iOS (#1284) * feat: Add useDisableIOSPinchZoomOnTouchDevices hook This commit adds a new hook called useDisableIOSPinchZoomOnTouchDevices to the frontend codebase. The hook is responsible for preventing pinch zoom gestures on iOS devices. It is used in the App component to disable pinch zoom on touch devices. * feat: Add touch-action property to disable pinch zoom on iOS * fix(style): Move percentage circle down 100% to align with background circle * fix: use vimeo for videos * fix: redefine ButtonArray button gaps * fix: docker compose without hyphen * fix: update podman-compose file names (#1290) * adjust debrief template * Fixed: Fix Circle percentage overlap issue (attempt 3) (#1291) * style: Move rotate transform and transform origin to the circle's svg level * story(AutoPlay): Add `AutoPlay` story * chore(deps): Update `package.json` version to `2.2.5` (#1293) * fix: remove non-breaking spaces when showing composer / ensemble / piece * fix: adjust scaling of image in th_preverbal * chore: update version * chore: remove unused import * Refactor: Remove `logoClickConfirm` and make user go to the experiment dashboard directly (#1303) * refactor: Remove `logoClickConfirm` and make user go to the experiment dashboard directly * chore(deps): Update package version to 2.2.7 --------- Co-authored-by: BeritJanssen <berit.janssen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new hook called useDisableIOSPinchZoomOnTouchDevices to the frontend codebase. The hook is responsible for preventing pinch zoom gestures on iOS devices. It is used in the App component to disable pinch zoom on touch devices. Additionally, the pull request includes necessary file changes to implement the hook and add the touch-action property to disable pinch zoom on iOS.
Additionally, the css-property
touch-action: manipulation;is added to the body root class in order to prevent touch actions.Resolves #1274