-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor block retrieval #1241
Refactor block retrieval #1241
Conversation
… wrapped in Trial)
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: backend/experiment/views.py
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some minor comments, but I found it hard to review this PR as I don't really understand what its intention is
theme?: Theme; | ||
class_name: string; | ||
rounds: number; | ||
playlists: Playlist[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These properties already exist on ExtendedBlock
so you can maybe remove them there (or here)
To clarify: the intention is that the |
Ah yes, but now I read back the changes I realize I also mixed in commits to remove the |
Co-authored-by: Drikus Roor <drikusroor@gmail.com>
…Music-Lab/MUSCLE into refactor/block-getter
This PR implements the last steps to close #973.