Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Add bonus_points to block view and use it in Matching Pairs #1168

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

drikusroor
Copy link
Contributor

@drikusroor drikusroor commented Jul 2, 2024

This PR adds the bonus_points property to block view and uses it in Matching Pairs as the starting value for the total score through the newly added block slice in the zustand store.

Additionally, the MatchingPairs component has been converted to TypeScript along with adding interfaces and types and slightly improving the component use of the index, which was ambiguously seen and used as a string and number.

Resolves #1165

@drikusroor drikusroor self-assigned this Jul 2, 2024
Copy link
Collaborator

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only wondering about the necessity of adding the loading state of block to the store.

The Block interface now includes a `bonus_points` property of type number. Additionally, the Section interface has been added with properties `id`, `group`, and `url`.
@drikusroor drikusroor merged commit afabc59 into develop Jul 9, 2024
13 checks passed
@drikusroor drikusroor deleted the feat/1165-use-bonus-points branch July 9, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatchingPairs: in frontend component, set the total score from the experiment's bonus_points field
2 participants