Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Serialize complete logo instead of just logo url and enable href feature on logo click #1116

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

drikusroor
Copy link
Contributor

Previously, the logo in the theme configuration was only serialized as a URL. This pull request updates the serialization to include the complete logo object, including the title, description, file, alt, href, rel, and target attributes. Additionally, it enables the href feature on logo click, allowing users to navigate to a specified URL when clicking on the logo.

Resolves #1115

@drikusroor drikusroor self-assigned this Jun 13, 2024
@drikusroor drikusroor merged commit c7c870b into develop Jun 13, 2024
14 checks passed
@drikusroor drikusroor deleted the feat/1115-serialize-logo-attributes branch June 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo should link to url configured on image
1 participant