Fix (CI): Fix frontend deployment #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* config: Set SENTRY_ENVIRONMENT to "test" and "acceptance" in relevant files so Sentry knows which environment it is running on (#972) * ci: Update podman.yml workflow conditions The `if` conditions in the `podman.yml` workflow file have been updated to include additional checks for the `workflow_dispatch` event. This ensures that the workflow is triggered correctly for the workflow dispatch button in combination with either the `develop` or the `main` branch. * chore: Update podman.yml workflow variables to avoid the vite build failing due to missing environment variables This commit updates the `podman.yml` workflow file to include additional variables related to the frontend HTML. These variables are used for the favicon, logo URL, Open Graph (OG) description, OG image, OG title, OG URL, and body class. The variables are set to empty strings if not provided. This change ensures that the workflow has the necessary variables for the frontend HTML. * ci: Temporarily turn on deploy for acceptance on this branch * chore: Try if manually setting the favicon fixes things * ci: Update podman.yml workflow variables to include frontend HTML environment variables This commit updates the `podman.yml` workflow file to include additional variables related to the frontend HTML. These variables are used for the favicon, logo URL, Open Graph (OG) description, OG image, OG title, OG URL, and body class. The variables are set to empty strings if not provided. This change ensures that the workflow has the necessary variables for the frontend HTML. * ci: Test deploy to test environment * chore: Update podman.yml workflow conditions for develop branch (cherry picked from commit 257b3a7)
drikusroor
changed the title
drikusroor
force-pushed
the
fix/deploy-acc
branch
from
89fd822
to
c8bad58
Compare
drikusroor
force-pushed
the
fix/deploy-acc
branch
from
d51363d
to
35061f1
Compare
drikusroor
force-pushed
the
fix/deploy-acc
branch
from
35061f1
to
8ca5219
Compare
drikusroor
force-pushed
the
fix/deploy-acc
branch
from
8ca5219
to
2bae67f
Compare
drikusroor
force-pushed
the
fix/deploy-acc
branch
from
2bae67f
to
319c441
Compare
drikusroor
force-pushed
the
fix/deploy-acc
branch
from
319c441
to
1472f07
Compare
drikusroor
force-pushed
the
fix/deploy-acc
branch
from
1472f07
to
1d4fdea
Compare
…nymore as I (Drikus) have confirmed that Acceptance works again
BeritJanssen
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several missing / incorrectly defined environment variables to the frontend build & deploy workflow and compose file and thereby fixes the deploy process.
Additionally, the rules for deployment have been altered to make it easier to manually deploy a branch:
mainbranch, it will deploy the currentmainbranch to the Acceptance environment.anyother branch, it will deploy that branch to the Test environment.Related to and cherrypicked from #1007 in order not to pollute the
mainbranch with features not ready to be released yet.