Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PresentationTexts to {org}/{app}/instances/{instanceOwnerPartyId}/active endpoint #177

Merged

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Jan 31, 2023

This is in preparation for showing presentation texts in the onEntry.Show = "select-instance" instance picker to help users and emulate the inbox in localtest, like requested in Altinn/app-localtest#3

Description

Backend support needs to come before frontend support. The goal is to add a new column if any of the instances has presentationTexts.

image

I'm sorry for including a few unrelated changes in this commit.

  • Added <ImplicitUsings>true to the Api project (same as in core)
  • Add nullable dictionary to IInstantiationProcessor. (The parameter is usually null, so this should be safe but causes a warning in apps)

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

…int}/active endpoint

This is in preparation for showing presentation texts in the
onEntry.Show = "select-instance" instance picker to help users
and emulate the inbox in localtest, like requested in
https://github.com/Altinn/altinn-studio/issues/8278
@tjololo tjololo added the external-contribution-❤️ Pull request from a developer outside the Altinn teams. label Feb 1, 2023
@tjololo tjololo self-assigned this Feb 1, 2023
@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label Feb 1, 2023
@tjololo tjololo merged commit 7475a1b into Altinn:main Feb 1, 2023
@ivarne ivarne deleted the exposePresentationTextsForActiveInstances branch February 1, 2023 10:46
ivarne added a commit to ivarne/app-lib-dotnet that referenced this pull request Feb 1, 2023
This is the same as Altinn#177,
but to add DueBefore in addition to PresentationValues
tjololo pushed a commit that referenced this pull request Feb 1, 2023
* Add DueBefore to /active instances endpoint

This is the same as #177,
but to add DueBefore in addition to PresentationValues

* Added test that dueBefore is mapped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contribution-❤️ Pull request from a developer outside the Altinn teams. feature Label Pull requests with new features. Used when generation releasenotes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants