Allow staged installation + import Rcpp::sourceCpp()
+ fix error in ConvertHexToBytes
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I have this all done right but I think this pull request may close out #4 and potentially could help with #6. Here are the key changes:
Rcpp::sourceCpp()
to imports (following guidance from Advanced R on using Rcpp in a package)|
for==
inutilities.cpp
)Building the package still returns a variety of warnings about the C++ code. I was able to address a couple obvious issues (removing unused variables this_compound_index and MAXPAGE) but I don't really know enough C++ to fix the other issues.
I also added a NEWS.md file to keep track of changes.