Deal with either Legacy XML or ASR XML #415
Annotations
10 errors and 13 warnings
Check formatting:
src/asr_xml.rs#L1
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/asr_xml.rs
|
Check formatting:
src/asr_xml.rs#L37
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/asr_xml.rs
|
Check formatting:
src/auto_splitter_settings.rs#L8
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting:
src/auto_splitter_settings.rs#L59
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting:
src/auto_splitter_settings.rs#L66
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting:
src/auto_splitter_settings.rs#L75
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting:
src/auto_splitter_settings.rs#L92
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting:
src/auto_splitter_settings.rs#L104
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting:
src/auto_splitter_settings.rs#L111
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting:
src/auto_splitter_settings.rs#L122
Diff in /home/runner/work/hollowknight-autosplit-wasm/hollowknight-autosplit-wasm/src/auto_splitter_settings.rs
|
Check formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, hecrj/setup-rust-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Check clippy lints
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, hecrj/setup-rust-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Check clippy lints:
src/hollow_knight_memory.rs#L1142
this `else { if .. }` block can be collapsed
|
Check clippy lints:
src/asr_xml.rs#L48
this expression creates a reference which is immediately dereferenced by the compiler
|
Check clippy lints:
src/asr_xml.rs#L49
this expression creates a reference which is immediately dereferenced by the compiler
|
Check clippy lints:
src/asr_xml.rs#L50
this expression creates a reference which is immediately dereferenced by the compiler
|
Check clippy lints:
src/asr_xml.rs#L55
this expression creates a reference which is immediately dereferenced by the compiler
|
Check clippy lints:
src/asr_xml.rs#L58
this expression creates a reference which is immediately dereferenced by the compiler
|
Check clippy lints:
src/asr_xml.rs#L59
this expression creates a reference which is immediately dereferenced by the compiler
|
Check clippy lints:
src/hollow_knight_memory.rs#L2715
using `clone` on type `bool` which implements the `Copy` trait
|
Check clippy lints:
src/hollow_knight_memory.rs#L2718
using `clone` on type `bool` which implements the `Copy` trait
|
Check clippy lints:
src/hollow_knight_memory.rs#L2797
using `clone` on type `bool` which implements the `Copy` trait
|
Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, hecrj/setup-rust-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|