-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inverter class rewritten #164
base: main
Are you sure you want to change the base?
Conversation
We should BE very carefull Here and a Lot of more Tests are required. The Inverter behaviour is very sensitive to Changes and Bugs are hard to find |
I increased the test coverage we do now test for:
let me know if you have other scenarios we should test. |
There are some things that should be done too but would extend the logic and im not sure how other parts of the optimization would react.
|
this should be the best test. i back ported the new test for the new class to the old class by only changing the import and the names of the function/variables called. minimal changes. |
Please re-run all tests, code changed quite a lot |
updated test_class_ems_2.py for the new class name
done. only a single very easy conflict and the new test did need the new class |
redo tests |
@drbacke please review this PR. I did every safety check i can think of. Before merging both _old files should be removed. |
self, generation: float, consumption: float, hour: int | ||
) -> Tuple[float, float, float, float]: | ||
losses = 0.0 | ||
grid_feed_in = 0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename grid_feed_in --> grid_export and
rename grid_draw --> grid_import
fully rewritten the inverter class
add tests
please check carefully
output from single_test_optimization.py is identical