-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of class_akku
to Battery
#130
Draft
fortrieb
wants to merge
195
commits into
main
Choose a base branch
from
refactoring/class_akku
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 stufige Optimierung, erst binär, dann mit float
PV Prognose aufsummieren der Strings eingebaut
Start ab Stunde X jetzt möglich
datetime.datetime.now() is incorrectly accessing the datetime class
- Optimized Imports: Removed unused imports and organized them. - Refactored Code: Introduced split_individual function for clarity. - Improved Efficiency: Enhanced penalty calculation and streamlined loops. - Updated Evaluation Logic: Better handling of penalties in evaluate. - Type Hints added - fixed seed option added for automated tests - verbose comment added, default False Notes: - isfloat is only used in flask_server.py - start_hour is not used in this class
…ockerfile for smaller builds
deleted comments flask_server path with os lib
removed comments fixed Bug in visualize.py (extra data empty) removed dead cp
test.py -> single_test_optimization.py
@fortrieb could you take a look into this PR? If you got no time id make a new one. Thanks |
I will resolve the conflicts this week. Last few weeks i haven't had much time to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Still a draft pull request. Will add type hints for all methods in
Battery
.