MessageList: swipe to go back #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajaxy
requested changes
Dec 21, 2023
| @@ -215,6 +215,38 @@ const MessageList: FC<OwnProps & StateProps> = ({ | |||
| memoFirstUnreadIdRef.current = firstUnreadId; | |||
| }, [firstUnreadId]); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
captureEvents: onSwipe is recommended for these purposes.
There was a problem hiding this comment.
In this PR, I propose adding functionality to handle back swipes specifically for Touch Bar swipes. The onSwipe handler in captureEvents is designed for touch and mouse events and does not detect wheel events generated by the MacBook's Touch Bar. The Touch Bar's unique wheel events have different characteristics and thresholds, which are not compatible with the onSwipe logic that's tailored for touch and mouse gestures.
There was a problem hiding this comment.
I see. I think that still needs to be handled within captureEvents module which already have this behavior for Media Viewer (onWheelDrag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding swipe left-to-right functionality for navigating back from the message list.