Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make max attempts adjustable #38

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented May 4, 2024

The default is set to one attempt, so it only tries once. The design is to let it fail at startup and have setup retry kick in so it tries again after startup and does not delay startup when it has a bit of trouble. Once a startup is done, the max_attempts can be set to a higher value since it will not delay the startup.

see home-assistant/core#116805

The default is set to one attempt so by default it
only tries once. The design is to let it fail at
startup and have setup retry kick in so it tries
again after startup and does not delay startup
when its have a bit of trouble. Once startup
has completed, the max_attempts can be set to
a higher value since it will not be delaying
startup.
Copy link
Member

@LaStrada LaStrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always! 🚀

@LaStrada LaStrada merged commit a817ac0 into Airthings:main May 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants