Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiplexed stream is not present in OriginMapStore Redis db #1682

Closed

Conversation

chakphanu
Copy link

@chakphanu chakphanu commented Aug 26, 2024

#1577

change syntax from

GetLinkedInputStream() != nullptr && GetLinkedInputStream()->IsFromOriginMapStore() == false
GetLinkedInputStream() GetLinkedInputStream()->IsFromOriginMapStore() GetLinkedInputStream() != nullptr && GetLinkedInputStream()->IsFromOriginMapStore() == false
nullptr N/A false
not nullptr false true
not nullptr true false

to

!(GetLinkedInputStream() != nullptr && GetLinkedInputStream()->IsFromOriginMapStore())
GetLinkedInputStream() GetLinkedInputStream()->IsFromOriginMapStore() GetLinkedInputStream() != nullptr && GetLinkedInputStream()->IsFromOriginMapStore() !(GetLinkedInputStream() != nullptr && GetLinkedInputStream()->IsFromOriginMapStore())
nullptr N/A false true
not nullptr false false true
not nullptr true true false

And for readble, create new private method OvtStream::IsFromOriginMapStore for reusing in OvtStream::Start() and OvtStream::Stop()

…cking if linked input stream is from OriginMapStore
@getroot getroot self-requested a review September 9, 2024 11:25
@getroot
Copy link
Member

getroot commented Sep 24, 2024

I reviewed the code again, its purpose is to prevent registering the stream generated from OriginMapStore again. Since the stream generated from OVT is an Input Stream itself (Relay mode), just checking IsFromOriginMapStore() was enough. Thanks for the PR.

@getroot getroot closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants