Properly advertise PAN/TILT read-only/autoupdate capabilities #19
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2024
The Linux kernel added some more input sanitization with kernel 6.10.3 (specifically patch torvalds/linux@8641968). We could add a quirk fix to the kernel, but it's a bit easier to update the hardware as well to behave more correctly. This will permit reading position data from the BNO on Linux once again. Resolves: Aharoni-Lab#13
|
@daharoni Hey :-) Is there a chance to get this merged? Meanwhile, another lab tested it on Windows as well, with no issues (but I would not have expected any anyway, as this does not impact the way the DAQ software on Windows queries the data. It also works with PoMiDAQ though, so I guess this solution works fine across the board). It would be nice to have this merged so any new boards come with the fixed firmware out of the box, and people don't think their BNO sensor is broken (especially since the Linux change that broke this came with a patch release of Linux, as it fixes a bunch of issues with regular camera devices... - but the Miniscope is special in the way it uses camera properties, so that's why the minor firmware edit exists). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This change fixes reading data from the BNO on newer Linux versions once again.
The Linux kernel added some more input sanitization with kernel 6.10.3
(specifically patch
torvalds/linux@8641968).
We could add a quirk fix to the kernel, but it's a bit easier to update
the hardware as well to behave more correctly.
The images have been rebuilt & tested locally, this change is also fairly small :-)
Best,
Matthias