Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildroot helpers #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Buildroot helpers #3

wants to merge 1 commit into from

Conversation

strijar
Copy link
Collaborator

@strijar strijar commented Dec 17, 2022

No description provided.

Copy link
Collaborator

@ruilvo ruilvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple comments, see them.

Also, I would like more if this was inside maybe scripts/buildroot, not just builldroot/, for project organization reasons. Other than that, I like it.

Comment on lines +14 to +22
-DBUILD_DOC=OFF \
-DBUILD_DOCS=OFF \
-DBUILD_EXAMPLE=OFF \
-DBUILD_EXAMPLES=OFF \
-DBUILD_TEST=OFF \
-DBUILD_TESTS=OFF \
-DBUILD_TESTING=OFF \
-DBUILD_SHARED_LIBS=ON \
-DBUILD_SHARED_LIB=ON
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the lines with S and without S? Only with S is correct.

Copy link
Collaborator Author

@strijar strijar Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the lines with S and without S? Only with S is correct.

This is exactly what buildroot does when it works. Just copy-paste

Also, I would like more if this was inside maybe scripts/buildroot, not just builldroot/, for project organization reasons. Other than that, I like it.

I don't think there will be any more scripts in this project. I don't see the need for this. So there is no point in making a subdirectory

./cmake.sh
make
./install.sh
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to say where the project needs to be pasted relative to the Buildroot directory? Just inside it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially because the conf.sh file hardcodes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants