-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildroot helpers #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple comments, see them.
Also, I would like more if this was inside maybe scripts/buildroot
, not just builldroot/
, for project organization reasons. Other than that, I like it.
-DBUILD_DOC=OFF \ | ||
-DBUILD_DOCS=OFF \ | ||
-DBUILD_EXAMPLE=OFF \ | ||
-DBUILD_EXAMPLES=OFF \ | ||
-DBUILD_TEST=OFF \ | ||
-DBUILD_TESTS=OFF \ | ||
-DBUILD_TESTING=OFF \ | ||
-DBUILD_SHARED_LIBS=ON \ | ||
-DBUILD_SHARED_LIB=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the lines with S
and without S
? Only with S
is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the lines with S and without S? Only with S is correct.
This is exactly what buildroot does when it works. Just copy-paste
Also, I would like more if this was inside maybe scripts/buildroot, not just builldroot/, for project organization reasons. Other than that, I like it.
I don't think there will be any more scripts in this project. I don't see the need for this. So there is no point in making a subdirectory
./cmake.sh | ||
make | ||
./install.sh | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to say where the project needs to be pasted relative to the Buildroot directory? Just inside it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially because the conf.sh
file hardcodes this.
No description provided.