Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advection for Neutrals #138

Merged
merged 120 commits into from
Aug 30, 2023
Merged

Advection for Neutrals #138

merged 120 commits into from
Aug 30, 2023

Conversation

robfleur
Copy link
Contributor

Before this change, all neutral species were advected (calculations for neutral friction were made considering ALL species). Now, when calculating neutral friction, only advected species will be calculated. Also, there is now a planet file option in aether.json (although the default is already specified as earth.in in defaults.json).

Type of change

  • New feature (non-breaking change that adds functionality)

How Has This Been Tested?

There is a script in tests/advect. It runs with no species advected, one species advected (N2), and all specified species advected.

Test configuration

  • Operating system: MacOS Ventura 13.1
  • Compiler, version number: Apple clang version 14.0.0 (clang-1400.0.29.202)

Checklist:

  • [N/A] Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [N/A] Add a note to CHANGELOG.md, summarizing the changes

@aaronjridley aaronjridley merged commit 055a7a3 into AetherModel:develop Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants