Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Message Exchange #136

Merged
merged 3 commits into from
Sep 11, 2023
Merged

[BUG] Message Exchange #136

merged 3 commits into from
Sep 11, 2023

Conversation

oscarhua
Copy link
Contributor

Description

Addresses #135

Now in the cubesphere grid, ghost cells are aligned with the current face and their values are linearly interpolated from other faces

Type of change

  • Bug fix (non-breaking change that fixes an issue)

How Has This Been Tested?

Run cmake with -DTEST_EXCHANGE:BOOL=TRUE and required changes to aether.json are described in src/main/main_test_exchange.cpp

Test configuration

  • Operating system: Ubuntu-20.04
  • Compiler, version number: gcc 9.4.0

Checklist:

  • [N/A] Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [N/A] Add a note to CHANGELOG.md, summarizing the changes

@aaronjridley aaronjridley merged commit 73c69b8 into AetherModel:develop Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants