Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix event emission for Vue 2 #283

Closed
wants to merge 1,140 commits into from
Closed

🐛 Fix event emission for Vue 2 #283

wants to merge 1,140 commits into from

Conversation

joao-m-santos
Copy link
Contributor

Fixes #238

📝 Description

  • Added event propagator function to all chart components (Vue 2 only)
  • Added a global variable for the Vue version

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

joao-m-santos and others added 30 commits November 22, 2022 16:40
@joao-m-santos @Lucas1981
♻️ Refactor portal logic for chart legend
85e46b5
@joao-m-santos @Lucas1981
♻️ Include helper classes to position legend correctly
a837160
@Lucas1981
⏪️ Reverting change to include helper classes to position legend in b…
862a260 
…ar chart
@Lucas1981
⏪️ Reverting change to include helper classes to position legend in b…
d1181c6 
…ar chart for bottom portal
@joao-m-santos
💚 Use npm install in PR workflow
65b369e
@joao-m-santos
💄 Change line/point default colors to skyblue
89429b7
@joao-m-santos
📝 Update legacy color references to new colors
0319e04
@joao-m-santos
📝 Update README
136bcaa
@joao-m-santos
🔖 0.1.5
b617827
@joao-m-santos
🔖 0.1.6
6158e2d
@vivy27 @joao-m-santos
📝 docs: add quick link for navigation (#104)
3c1f41a 
Signed-off-by: Vivian Joseph <vivy27@gmail.com>
Co-authored-by: joao <joao.dossantos@adyen.com>
@joao-m-santos
♻️ Use portal to broker for the chart legend in the lume chart compo… (…
7864e12 
…#97)
@joao-m-santos
📝 Update README
efe9ddb
@vivy27
➕ add deps
6c23454
@vivy27
🔧 add vitest config
dca36ef
@vivy27
🔧 update auto vitest global imports
faddbfc
@vivy27
👽️ replace jest with vi
3828b12
@vivy27
⬇️ downgrade vue version
9d0c1c3
@vivy27
✅ temporary fix for bar charts
37eee1f
@vivy27
🔥 remove css from vitest config
081d6bf
@vivy27
🔥 remove jest and istanbul config files
d75c882
@vivy27
🔧 update npm commands and config
d668215
@joao-m-santos
✅ Pass failing tests
77a695b
@joao-m-santos
👷 Update PR workflow
2387502
@joao-m-santos
✨ Introduce vitest for test (#101)
a909353
@joao-m-santos @Lucas1981
♻️ Rough setup to move out the logic from the line and line-group co… (…
0d97e2f 
…#103)

Co-authored-by: Lucas van Heerikhuizen <lucas.vanheerikhuizen@adyen.com>
@Lucas1981
✨ Make sure portals are scoped to component by using a unique id gene…
28cb364 
…rator
@Lucas1981
🔥 Sticking to chartID provided by base to arrive at unique id for lum…
d7c58a9 
…e-chart
@Lucas1981
Merge branch 'main' into 107-make-sure-vue-portal-destinations-are-un…
a0062fc 
…iquely-scoped-to-the-component
@joao-m-santos
✨ Introduce format composable
44f50fa
joao-m-santos and others added 19 commits August 8, 2023 16:22
@joao-m-santos
📝 Update README
2c2d4a6
@govind-srinidhi
📝 Added documentation for alluvial-group
fa4ac95
@govind-srinidhi
📝 Refined stories for all lume charts
30692f3
@govind-srinidhi
📝 Removed figma links from all stories
3fea7ac
@govind-srinidhi
✅ Updated test to accomodate changes in alluvial data
f90581d
@joao-m-santos
🐛 Fix stacked bar chart not applying padding values
5dd1f8b
@joao-m-santos
✅ Update unit tests
2f1f9e9
@joao-m-santos
🔖 Release v0.9.0
8f52240
@joao-m-santos
🔧 Update publish config
96b8698
@joao-m-santos
♻️ Refactor Bar chart stories; Fix related issues
7bc63f8
@joao-m-santos
♻️ Refactor all other stories to CSF3
08b1196
@joao-m-santos
🚸 Improve tick padding behavior
53b1654
@joao-m-santos
🎨 Improve Alluvial link ID code
1ad631d
@joao-m-santos
🐛 Use correct color for gradient in node color derivation
be1850b
@joao-m-santos
🔖 Release v0.9.1
149fe9f
@joao-m-santos
🔧 Update workflow config
aa78f02
@joao-m-santos
⬆️ Upgrade package versions & fix them
f0d5037
@joao-m-santos
⬆️ Upgrade dependencies
2a58e86
@joao-m-santos
🐛 Fix event emission for Vue 2
4ea5e9a
@joao-m-santos joao-m-santos self-assigned this Sep 1, 2023
@joao-m-santos joao-m-santos linked an issue Sep 1, 2023 that may be closed by this pull request
Events API not working properly in Vue 2 #238
Closed
5 tasks
@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit a53ee7a
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/64f73303368cac0008460e37
😎 Deploy Preview https://deploy-preview-283--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joao-m-santos joao-m-santos marked this pull request as ready for review September 5, 2023 14:05
@joao-m-santos joao-m-santos requested a review from a team as a code owner September 5, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@govind-srinidhi govind-srinidhi Awaiting requested review from govind-srinidhi

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events API not working properly in Vue 2
6 participants
@joao-m-santos @Lucas1981 @vivy27 @a-thomasdobber @adyendrivera @govind-srinidhi