Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Implement a orthogonal probe relaxation function #101

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

carterbox
Copy link
Contributor

@carterbox carterbox commented Nov 6, 2020

Purpose

Implementing orthrogonal probe relaxation.

Approach

Instead of a common probe, the probe at each scan position is allowed to be slightly different from the others. This is accomplished by having each probe a weighted average of a unique probe and the first N principal components of all of the probes.

Pre-Merge Checklists

Submitter

  • Write a helpfully descriptive pull request title.
  • Organize changes into logically grouped commits with descriptive commit messages.
  • Document all new functions.
  • Write tests for new functions or explain why they are not needed.
  • Build the documentation successfully
  • Use yapf to format python code.

Reviewer

  • Actually read all of the code.
  • Run the new code yourself.
  • Write a summary of the changes as you understand them.
  • Thank the submitter.

@pep8speaks
Copy link

pep8speaks commented Nov 6, 2020

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 133:9: E741 ambiguous variable name 'I'
Line 143:5: E301 expected 1 blank line, found 0

Line 481:47: W605 invalid escape sequence '\s'
Line 572:81: E501 line too long (81 > 80 characters)

Line 72:81: E501 line too long (85 > 80 characters)

Comment last updated at 2021-09-28 16:21:54 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants