fix(exr): Avoid integer overflow for large deep exr slice strides #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original reporter of #4540 reported there that they applied this patch on their end and it fixes the problem. |
jessey-git
reviewed
Nov 28, 2024
src/openexr.imageio/exroutput.cpp
Outdated
| @@ -1729,15 +1729,15 @@ OpenEXROutput::write_deep_scanlines(int ybegin, int yend, int /*z*/, | |||
| frameBuffer.insertSampleCountSlice(countslice); | |||
| std::vector<void*> pointerbuf; | |||
| dd->get_pointers(pointerbuf); | |||
| size_t slchans = size_t(m_spec.width) * size_t(nchans); | |||
There was a problem hiding this comment.
The only thing that caused me to do a double-take in this PR is that this line doesn't mirror the form used in exrinput. Can we declare nchans as size_t above (assuming m_spec.nchannels is already known to be >= 0) so that this entire block of code will match what is used in exrinput? i.e. there's 3 casts to size_t in this block whereas the ones in exrinput has none.
There was a problem hiding this comment.
Yeah, that makes sense
There was a problem hiding this comment.
So updated (delay was for fixing the great GHA failure of 2024).
Fixes 4540 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Larry Gritz <lg@larrygritz.com>
jessey-git
approved these changes
Nov 29, 2024
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 30, 2024
…ademySoftwareFoundation#4542) Fixes AcademySoftwareFoundation#4540 --------- Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4540