Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#66: Compression mode control #72

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

#66: Compression mode control #72

wants to merge 5 commits into from

Conversation

shubertm
Copy link
Member

#66

@shubertm shubertm requested review from kirillt and mdrlzy July 13, 2023 09:57
@kirillt
Copy link
Member

kirillt commented Jul 28, 2023

  1. Make a screenshot.
  2. See system pop-up with options.
  3. Click [edit] button.
  4. Crash.

I guess, we need to adjust code handling opening via intents.
Also, ACRA can't send crash log in this case.

  • Fix possibility to edit freshly made screenshot via system pop-up
  • Look if it's possible to initialize ACRA in this case

The crash log:

java.nio.file.FileSystemNotFoundException: Provider "content" not installed
    at java.nio.file.Paths.get(Paths.java:147)
    at space.taran.arkretouch.presentation.edit.EditViewModel.loadImage(EditViewModel.kt:130)
    at space.taran.arkretouch.presentation.edit.EditScreenKt$DrawContainer$2.invoke-ozmzZPI(EditScreen.kt:327)
    at space.taran.arkretouch.presentation.edit.EditScreenKt$DrawContainer$2.invoke(EditScreen.kt:287)
    at androidx.compose.ui.layout.OnSizeChangedModifier.onRemeasured-ozmzZPI(OnRemeasuredModifier.kt:65)
    at androidx.compose.ui.node.BackwardsCompatNode.onRemeasured-ozmzZPI(BackwardsCompatNode.kt:438)
    at androidx.compose.ui.node.NodeCoordinator.onMeasured(NodeCoordinator.kt:308)
    at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:105)
    at androidx.compose.foundation.layout.PaddingModifier.measure-3p2s80s(Padding.kt:364)
    at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:343)

ACRA crashed too:

Failed to send crash reports for /data/user/0/space.taran.arkretouch2/app_ACRA-approved/2023-07-28T16:22:12.013+03:00.stacktrace
org.acra.sender.ReportSenderException: Policy marked this task as incomplete. ACRA will try to send this report again.
    at org.acra.sender.ReportDistributor.sendCrashReport(ReportDistributor.kt:109)
    at org.acra.sender.ReportDistributor.distribute(ReportDistributor.kt:65)
    at org.acra.sender.SendingConductor.sendReports(SendingConductor.kt:50)
    at org.acra.sender.JobSenderService.onStartJob$lambda-0(JobSenderService.kt:24)
    at org.acra.sender.JobSenderService.$r8$lambda$8hqjpgI4F1h0OfXMJ-OHV3fLVWk(Unknown Source:0)
    at org.acra.sender.JobSenderService$$ExternalSyntheticLambda0.run(Unknown Source:8)
    at java.lang.Thread.run(Thread.java:920)
Caused by: org.acra.sender.ReportSenderException: Error while sending JSON report via Http POST
    at org.acra.sender.HttpSender.send(HttpSender.kt:116)
    at org.acra.sender.ReportSender.send(ReportSender.kt:59)
    at org.acra.sender.ReportDistributor.sendCrashReport(ReportDistributor.kt:101)
    at org.acra.sender.ReportDistributor.distribute(ReportDistributor.kt:65) 
    at org.acra.sender.SendingConductor.sendReports(SendingConductor.kt:50) 
    at org.acra.sender.JobSenderService.onStartJob$lambda-0(JobSenderService.kt:24) 
    at org.acra.sender.JobSenderService.$r8$lambda$8hqjpgI4F1h0OfXMJ-OHV3fLVWk(Unknown Source:0) 
    at org.acra.sender.JobSenderService$$ExternalSyntheticLambda0.run(Unknown Source:8) 
    at java.lang.Thread.run(Thread.java:920) 
Caused by: java.net.MalformedURLException: no protocol: 
    at java.net.URL.<init>(URL.java:601)
    at java.net.URL.<init>(URL.java:498)
    at java.net.URL.<init>(URL.java:447)
    at org.acra.sender.HttpSender$Method$POST.createURL(HttpSender.kt:189)
    at org.acra.sender.HttpSender.send(HttpSender.kt:112)
    at org.acra.sender.ReportSender.send(ReportSender.kt:59) 
    at org.acra.sender.ReportDistributor.sendCrashReport(ReportDistributor.kt:101) 
    at org.acra.sender.ReportDistributor.distribute(ReportDistributor.kt:65) 
    at org.acra.sender.SendingConductor.sendReports(SendingConductor.kt:50) 
    at org.acra.sender.JobSenderService.onStartJob$lambda-0(JobSenderService.kt:24) 
    at org.acra.sender.JobSenderService.$r8$lambda$8hqjpgI4F1h0OfXMJ-OHV3fLVWk(Unknown Source:0) 
    at org.acra.sender.JobSenderService$$ExternalSyntheticLambda0.run(Unknown Source:8) 
    at java.lang.Thread.run(Thread.java:920) 

@shubertm shubertm temporarily deployed to Development August 3, 2023 20:18 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development August 3, 2023 20:20 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development August 3, 2023 20:20 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development August 5, 2023 10:27 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development August 5, 2023 10:29 — with GitHub Actions Inactive
@shubertm shubertm temporarily deployed to Development August 5, 2023 10:29 — with GitHub Actions Inactive
@kirillt
Copy link
Member

kirillt commented Aug 6, 2023

We still need to extract original compression configuration from an image:
compression_variants
Selected items on the screenshot are original images, the rest are versions saved from our app.


Here is some details from mediainfo regarding saving into JPG:
compression_mediainfo

@shubertm
Copy link
Member Author

shubertm commented Aug 6, 2023

We still need to extract original compression configuration from an image:
compression_variants
Selected items on the screenshot are original images, the rest are versions saved from our app.


Here is some details from mediainfo regarding saving into JPG:
compression_mediainfo

Has extraction stopped working? I did not notice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants