Replace Double with BigDecimal #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubertm
reviewed
Oct 14, 2024
| return Gson().toJson(list, type) | ||
| val type = object : TypeToken<List<AmountStr>>() {}.type | ||
| val listStr = list.map { it.toStrAmount() } | ||
| return Gson().toJson(listStr, type) |
There was a problem hiding this comment.
We could use Kotlin Serialization here
There was a problem hiding this comment.
I think it's fine to use Gson as it is the Json parsing lib in our project. If use Kotlin Serialization we have to add more dependency
There was a problem hiding this comment.
I think there won't be much difference between kotlin serialization and gson. Considering there is less code with gson
hieuwu
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double has poor precision which can be problem when working with currencies.