Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use affine transformations for low-level movement logic #716

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oh-noey
Copy link
Collaborator

@oh-noey oh-noey commented Sep 15, 2024

Describe in detail what your pull request accomplishes

This is the first in a (hopefully) series of PRs to converge Movecraft's translation and rotation systems by leveraging affine transformations. Affine transforms offer the ability to concisely represent these operations as a singular composable unit, which makes implementing code using them much simpler than our current methodologies.

One caveat is that the current implementation uses workarounds to decompose the transformations into its component parts (translation and rotation - in general there's also scaling for example). We have no use for more complex operations so they are left out.

To better support this system, it may be desirable to pre-bake the vector representation of our MovecraftLocation into the location objects - this will require performance testing.

Checklist

  • Unit tests
  • Proper internationalization
  • Tested
  • Performance tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant