small hitbox and sink fix #715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed hardcoded sink limit from `y < 5` to `y < (craft.getWorld().getMinHeight() + 5)` preserving the original 4 block buffer but accounting for the new minimum world heights of 1.18+
Adjusted X, Y, Z, lengths by +1 to compensate for coordinate vs block math.
oh-noey
reviewed
Sep 14, 2024
Movecraft/src/main/java/net/countercraft/movecraft/async/AsyncManager.java
Outdated
Show resolved
Hide resolved
oh-noey
reviewed
Sep 15, 2024
| @@ -293,7 +293,7 @@ private void processSinking() { | |||
| if (!(craft instanceof SinkingCraft)) | |||
| continue; | |||
|
|
|||
| if (craft.getHitBox().isEmpty() || craft.getHitBox().getMinY() < 5) { | |||
| if (craft.getHitBox().isEmpty() || craft.getHitBox().getMinY() < (craft.getWorld().getMinHeight() +5 )) { | |||
There was a problem hiding this comment.
Just a thought but is their really any reason we even check for it being 5 over the min in the firs place 🤔
There was a problem hiding this comment.
I removed it on my fork and everything works fine. I kept it here because I didn't know if there were any other classes that need it.
oh-noey
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixed the off-by-1 hitbox math and the hardcoded y < 5 sink limits
Checklist