Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields in ExpData HDF5 I/O #2593

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 23, 2024

Closes #2589

@dweindl dweindl requested a review from a team as a code owner November 23, 2024 17:28
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 31.14754% with 42 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (7ba2165) to head (c0b161d).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/hdf5.cpp 31.14% 42 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2593      +/-   ##
===========================================
- Coverage    77.63%   77.50%   -0.13%     
===========================================
  Files          329      329              
  Lines        22061    22122      +61     
  Branches      1456     1474      +18     
===========================================
+ Hits         17126    17145      +19     
- Misses        4924     4966      +42     
  Partials        11       11              
Flag Coverage Δ
cpp 73.44% <31.14%> (-0.12%) ⬇️
cpp_python 34.20% <0.00%> (-0.10%) ⬇️
petab 37.09% <0.00%> (-0.15%) ⬇️
python 72.20% <6.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/hdf5.cpp 84.48% <31.14%> (-4.53%) ⬇️
---- 🚨 Try these New Features:

@dweindl dweindl merged commit 7b9340f into AMICI-dev:develop Nov 24, 2024
16 of 20 checks passed
@dweindl dweindl deleted the fix_2589 branch November 24, 2024 09:20
@dweindl dweindl linked an issue Nov 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

writeSimulationExpData does not store all ExpData fields
2 participants