Warn if ASA is used in combination with events

[dweindl]

#18

[codecov]

Codecov Report

Merging #2097 (3c94976) into develop (d301df6) will decrease coverage by 22.13%.
The diff coverage is 50.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #2097       +/-   ##
============================================
- Coverage    76.51%   54.38%   -22.13%     
============================================
  Files           81       33       -48     
  Lines        14853     5516     -9337     
============================================
- Hits         11365     3000     -8365     
+ Misses        3488     2516      -972     

Flag	Coverage Δ
cpp	?
petab	54.38% <50.00%> (-0.01%)	⬇️
python	?
sbmlsuite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
python/sdist/amici/swig_wrappers.py	66.26% <50.00%> (-29.94%)	⬇️

... and 64 files with indirect coverage changes

[FFroehlich]

‚ne‘ counts discontinuities in the rhs and x. Discontinuities in the rhs are fine with adjoint sensitivity analysis as long as the trigger function is not parameter dependent.

[dweindl]

‚ne‘ counts discontinuities in the rhs and x. Discontinuities in the rhs are fine with adjoint sensitivity analysis as long as the trigger function is not parameter dependent.

Ok, thanks. As this is not apparent from the generated model module, and i don't feel like storing it there - how do we want to handle that?

1. change the message and live with the warnings for non-parameter-dependent trigger functions
2. rather warn once during model import
3. leave it as it was before (no warning)

[FFroehlich]

‚ne‘ counts discontinuities in the rhs and x. Discontinuities in the rhs are fine with adjoint sensitivity analysis as long as the trigger function is not parameter dependent.

Ok, thanks. As this is not apparent from the generated model module, and i don't feel like storing it there - how do we want to handle that?

1. change the message and live with the warnings for non-parameter-dependent trigger functions
2. rather warn once during model import
3. leave it as it was before (no warning)

Hmm rephrase warning and state that it might not apply to the model at hand, i.e. 1.?