Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: More verbose message for missing configs on update-queries #230

Closed
wants to merge 5 commits into from

Conversation

Simaris
Copy link

@Simaris Simaris commented Apr 16, 2019

Fix #226

  • Fix
  • Tests
    • Isolate Test with docker or similar technology

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.588% when pulling 42be2d0 on Simaris:feature/verbose_message into 79293ca on AKSW:master.

@coveralls
Copy link

coveralls commented Apr 16, 2019

Coverage Status

Coverage decreased (-0.1%) to 74.865% when pulling 80d1db2 on Simaris:feature/verbose_message into 1a81c33 on AKSW:master.

@Simaris Simaris changed the title More verbose message for missing configs on update-queries WIP: More verbose message for missing configs on update-queries Apr 16, 2019
Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user.name is set I get the message:

Unable to process query: git config value 'user.name' was not found.
Pls use the following command in your data repo:

  git config user.email <your email>

Especially git config value 'user.name' was not found. is wrong.

Also please be more verbose and don't just write Pls.

@white-gecko
Copy link
Member

This causes problems, maybe because of the new pygit2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let quit indicate if no user.name and user.email is set
3 participants