Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure iterators satisfy input_iterator concept for views and ranges #273

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Ensure iterators satisfy input_iterator concept for views and ranges #273

wants to merge 23 commits into from

Commits on Aug 1, 2022

  1. input_iterator type and unit tests

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    383efc6 View commit details
    Browse the repository at this point in the history

  2. Make checks happy by using all variables

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    540eae4 View commit details
    Browse the repository at this point in the history

  3. Haha, get past the sanitzer checks

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    db113f8 View commit details
    Browse the repository at this point in the history

  4. Add reverse iterators; split tests into iterators and views

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    dc6c782 View commit details
    Browse the repository at this point in the history

  5. Add prefix to iterator types; change to bidirectional_iterator_tag

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    f74e64e View commit details
    Browse the repository at this point in the history

  6. Add iterator default constructor (index 0, nullptr)

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    d2c783b View commit details
    Browse the repository at this point in the history

  7. No getter for PDG in read_views test

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    07fc73a View commit details
    Browse the repository at this point in the history

  8. Const dereference with mutable m_object

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    3ae4087 View commit details
    Browse the repository at this point in the history

  9. Full(er) set of unit tests (incl c++23 zip)

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    f83d7bc View commit details
    Browse the repository at this point in the history

  10. Single line import of iterator_definitions 

    Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
    @wdconinc @tmadlener
    wdconinc and tmadlener committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    853423b View commit details
    Browse the repository at this point in the history

  11. Remove reserve for sized_range since not available for podio collection

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    a71f643 View commit details
    Browse the repository at this point in the history

  12. Suggested style change 

    Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
    @wdconinc @tmadlener
    wdconinc and tmadlener committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    74e4691 View commit details
    Browse the repository at this point in the history

  13. static_assert on iterator_traits for bidirectional_iterator_tag

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    4b5cf9f View commit details
    Browse the repository at this point in the history

  14. dereference operator* const to copy without mutable inside iterator

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    d18b1d6 View commit details
    Browse the repository at this point in the history

  15. Remove read_iterators.cpp read_views.cpp again; put in unittests

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    7e6672e View commit details
    Browse the repository at this point in the history

  16. Examples on using for_each, ranges, etc

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    aedafdb View commit details
    Browse the repository at this point in the history

  17. shouldfail unit test for std::fill; added for_each to unit test

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    01f935a View commit details
    Browse the repository at this point in the history

  18. clang-format fixes

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    8291978 View commit details
    Browse the repository at this point in the history

  19. Limit iterator types to input_iterator

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c795898 View commit details
    Browse the repository at this point in the history

  20. Require input_iterator and nothing more; split off ranges tests

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    784b902 View commit details
    Browse the repository at this point in the history

  21. Fix clang-format on unit tests

    @wdconinc
    wdconinc committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    9fed18f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. fix: add test case tags as suggested 

    Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
    @wdconinc @tmadlener
    wdconinc and tmadlener authored Aug 2, 2022
    Configuration menu
    Copy the full SHA
    b541675 View commit details
    Browse the repository at this point in the history

  2. fix: ifdef guard entire test case as suggested 

    Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
    @wdconinc @tmadlener
    wdconinc and tmadlener authored Aug 2, 2022
    Configuration menu
    Copy the full SHA
    ec3e58e View commit details
    Browse the repository at this point in the history