Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner: actually sign aggregate transaction inputs #65

Merged

Conversation

DaMatrix
Copy link

Description

Previously, aggregation transactions never actually got signed, and were being submitted to the mempool with an empty redeem script.

Changelog

  • List the changes to the codebase that this PR introduces

Type of Change

Please mark the appropriate option by putting an "x" inside the brackets:

  • Bug fix
  • New feature
  • Enhancement or optimization
  • Documentation update
  • Other (please specify)

Checklist

Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have tested the changes locally and they work as expected.
  • I have added necessary documentation or updated existing documentation.
  • My code follows the project's coding standards and style guidelines.
  • I have added/updated relevant tests to ensure the changes are properly covered.
  • I have checked for and resolved any merge conflicts.
  • My commits have clear and descriptive messages.

Screenshots (if applicable)

If the changes affect the UI or have visual effects, please provide screenshots or GIFs showcasing the changes.

Additional Context (if applicable)

Add any additional context or information about the changes that may be helpful in understanding the pull request.

Related Issues (if applicable)

If this pull request is related to any existing issues, please list them here.

Requested Reviewers

Mention any specific individuals or teams you would like to request a review from.

Previously, aggregation transactions never actually got signed, and were being submitted to the mempool with an empty redeem script.
@DaMatrix DaMatrix requested a review from a team as a code owner May 11, 2024 19:12
@BHouwens BHouwens merged commit 087a27b into AIBlockOfficial:develop May 13, 2024
0 of 3 checks passed
@DaMatrix DaMatrix deleted the dev/sign_miner_aggregate_txn branch May 13, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants