Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement REST API endpoint, service, and tests for CheckBalance feature #104

Merged
merged 13 commits into from
Apr 9, 2024
Merged

Implement REST API endpoint, service, and tests for CheckBalance feature #104

merged 13 commits into from
Apr 9, 2024

Conversation

NkwaTambe
Copy link
Collaborator

No description provided.

stephane-segning
stephane-segning requested changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @NkwaTambe! Just this small point to review

...ackend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalanceImpl.java Outdated Show resolved Hide resolved
stephane-segning
stephane-segning requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work! Please review these points

...ackend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalanceImpl.java Outdated Show resolved Hide resolved
.../src/test/java/com/adorsys/gis/powerpay/powerpaybackend/services_tests/CheckBalanceTest.java Outdated Show resolved Hide resolved
@NkwaTambe
Copy link
Collaborator Author

Please sir @stephane-segning review new changes

stephane-segning
stephane-segning requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

...src/main/java/com/adorsys/gis/powerpay/powerpaybackend/repository/TransactionRepository.java Show resolved Hide resolved
@NkwaTambe NkwaTambe self-assigned this Apr 8, 2024
stephane-segning
stephane-segning approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @NkwaTambe !

Koufan-De-King
Koufan-De-King approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@Koufan-De-King Koufan-De-King left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right!

Motouom
Motouom approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@Motouom Motouom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, all good

@NkwaTambe NkwaTambe merged commit 2868306 into ADORSYS-GIS:main Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Motouom Motouom Motouom approved these changes

@Koufan-De-King Koufan-De-King Koufan-De-King approved these changes

@stephane-segning stephane-segning stephane-segning approved these changes

Assignees

@NkwaTambe NkwaTambe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NkwaTambe @stephane-segning @Koufan-De-King @Motouom