Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/use storage hook #100

Merged
merged 16 commits into from
Apr 9, 2024
Merged

Feature/use storage hook #100

merged 16 commits into from
Apr 9, 2024

Conversation

Christiantyemele
Copy link
Collaborator

No description provided.

@Christiantyemele
docs(useStorage): useStorage hook documentation
0ff29c4
@Christiantyemele
feat(hooks): implementing the useStorage hook
93a0a40
@Christiantyemele
test(usestorage): simple implementation to test the useStorage hook
2f200cf
@Christiantyemele
docs(useStorage): useStorage hook documentation
71788eb
@Christiantyemele
feat(useStorage): implementing the useStorage hook
72566ff
@Christiantyemele
test(useStorage): simple usecase to test useStorage hook
3de282d
@Christiantyemele
docs(useStorage): documentation on the choice and reason for the libr…
3fce927 
…ary to use for the useStorage hook
@Christiantyemele
docs(useStorage): useStorage documentation and library used
052b220
@Christiantyemele
fix(frontend): removing Hooks and Tests folders from frontend
1bd5484
@Christiantyemele
docs(useStorage): removing unnecessary information in useStorage docs
c57fc2f
@Christiantyemele
docs(useStoragedocs): adding visual representation of flow
10aab0e
@Christiantyemele
docs(useStorage): visual representation of usestorage docs
5823bdd
@Christiantyemele
Copy link
Collaborator Author

@stephane-segning i have modified the useStorage docs and requesting for review

stephane-segning
stephane-segning requested changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@stephane-segning stephane-segning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Christiantyemele! You added the doc for indexeddb. Do the same in the file for localstorage and websql please and give this file a good structure. Also, after that, explain which one is better and why.

@Christiantyemele
Copy link
Collaborator Author

Christiantyemele commented Mar 23, 2024 •
edited
Loading

Good evening sir @stephane-segning so i should explain again localstorage, websql and explain which will be better between these three including indexdb ? .

@Christiantyemele
Copy link
Collaborator Author

Hello sir @stephane-segning indexxed implementation and test ready and requesting review

@Christiantyemele
Copy link
Collaborator Author

@AssahBismarkabah and @Elwizzy12 please requesting for review on this PR

stephane-segning
stephane-segning approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seal of quality!

@Christiantyemele
Copy link
Collaborator Author

Seal of quality!

Thank you sir @stephane-segning 🤝 , 🤛

@Christiantyemele
Copy link
Collaborator Author

🤝 to @AssahBismarkabah

@Christiantyemele
Copy link
Collaborator Author

just remaining your review @Elwizzy12

Elwizzy12
Elwizzy12 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@Elwizzy12 Elwizzy12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@Christiantyemele Christiantyemele force-pushed the feature/useStorage-Hook branch 4 times, most recently from 6b77051 to 93369a9 Compare April 9, 2024 10:51
@Christiantyemele Christiantyemele self-assigned this Apr 9, 2024
@Christiantyemele Christiantyemele force-pushed the feature/useStorage-Hook branch 3 times, most recently from 93369a9 to d44d91f Compare April 9, 2024 12:25
@Christiantyemele Christiantyemele linked an issue Apr 9, 2024 that may be closed by this pull request
Implement a hooks for persisting data on the frontend #38
Closed
@Christiantyemele Christiantyemele force-pushed the feature/useStorage-Hook branch 8 times, most recently from d9d7f64 to 5823bdd Compare April 9, 2024 13:58
@Christiantyemele Christiantyemele merged commit 4555549 into ADORSYS-GIS:main Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AssahBismarkabah AssahBismarkabah AssahBismarkabah approved these changes

@Elwizzy12 Elwizzy12 Elwizzy12 approved these changes

@stephane-segning stephane-segning stephane-segning approved these changes

Assignees

@Christiantyemele Christiantyemele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a hooks for persisting data on the frontend
4 participants
@Christiantyemele @stephane-segning @Elwizzy12 @AssahBismarkabah