-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to build MOM5 with an external FMS and Generic Tracers using Spack #29
base: master
Are you sure you want to change the base?
Conversation
FYI, I decided not to include this commit in this PR for the sake of simplicity:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 150 sets lib_include_dirs
which is used in all the component build scripts
set lib_include_dirs = "$root/include $code_dir/shared/include $code_dir/shared/mpp/include"
I think it should also be bracketed with logic to test for external FMS.
@@ -260,8 +264,12 @@ if( $type == ACCESS-OM || $type == ACCESS-ESM) then | |||
set srcList = ( $srcList access/shared ) | |||
endif | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be bracketed in logic that checks for an external FMS too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/access/shared/gtracer_flux.F90:
module gtracer_flux_mod
It looks like it's required:
$ rg 'use gtracer_flux_mod' *
src/access/accesscm_coupler/mom_oasis3_interface.F90
97:use gtracer_flux_mod, only: set_coupler_type_data, extract_coupler_type_data
src/access/accesscm_coupler/ocean_solo.F90
158: use gtracer_flux_mod, only: flux_exchange_init, atmos_ocean_fluxes_calc
159: use gtracer_flux_mod, only: gas_fields_restore, gas_fields_restart
src/access/accessom_coupler/ocean_solo.F90
115: use gtracer_flux_mod, only: flux_exchange_init, atmos_ocean_fluxes_calc
116: use gtracer_flux_mod, only: gas_fields_restore, gas_fields_restart
src/access/accessom_coupler/mom_oasis3_interface.F90
109:use gtracer_flux_mod, only: set_coupler_type_data
a90562b
to
c662cd5
Compare
least intrusive and simple way to introduce this feature.