Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CreateOperationContext() in Executor by using sync.Pool #3370

Closed
wants to merge 4 commits into from

Conversation

lkeix
Copy link
Contributor

@lkeix lkeix commented Nov 11, 2024

Describe your PR and link to any relevant issues.

#3362

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Nov 11, 2024

Coverage Status

coverage: 59.62% (+0.07%) from 59.549%
when pulling 5091920 on lkeix:master
into aaf44f5 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Hey, I appreciate trying to make performance improvements in gqlgen, but it looks like there's a fair number of test failures with this current code.

@lkeix
Copy link
Contributor Author

lkeix commented Nov 12, 2024

@StevenACoffman
I attempted optimization using sync.Pool, but due to race conditions between WebSocket and POST requests, preventing resource conflicts proved challenging.
Additionally, forcing the use of sync.Pool in this context would lead to an overly complex implementation. Given these issues, I’m planning to close this PR.
Thank you for your time and feedback.

@lkeix lkeix closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants