Allow other formats when unmarshalling time #1964
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the method that unmarshalls times a bit more flexible.
Currently, only dates that are in full RFC339 format are supported, strictly. This adds a couple more formats relaxing the parser:
2006-01-02 15:04:05.999999999
-> allows things like2022-02-10 10:20:30
(nanoseconds are optional)2006-01-02
-> allowing things like2022-02-10
(which defaults to midnight)When a time zone is not specified, it defaults to UTC (as the default for
time.Parse
)I have: