Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Game Creation dialog #7179

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Conversation

ClementPasteau
Copy link
Collaborator

@ClementPasteau ClementPasteau commented Nov 20, 2024

Lots of changes including:

  • ExampleStoreDialog has been removed and all previous links now point to the NewProject dialog
  • The page accessible from "Browse all templates" on the build section, now shows all templates, games first
  • the new project dialog now shows a mix of "empty project" / "project bases" / "examples" / "game templates" / AI generation, with a search
  • all previous game template or example links now point to the NewProject dialog, with the item selected
  • new 3 starting points templates

@AlexandreSi
Copy link
Collaborator

AlexandreSi commented Nov 22, 2024

First impressions:

  • Why is the "Optimize for pixel art" checkbox not available on the 3 starter templates?
  • The disabled Create new game dialog action maybe gives the feeling that I can click on it if I check something. Should it not be displayed in the first screen?
  • The top down thumbnail is not straight forward in a first glance, I thought it was a different kind of platformer

<Column>
{isMobile && <Spacer />}
<Line justifyContent="flex-start" noMargin>
{/* Add a hidden text to match the height of the other tiles on the row */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the grid should normally handle that, is it really needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a height: 100% is needed somewhere

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's needed, because the other elements have 2 items : image & title below.
In order to have the "empty project" element (that is inside the tile) match the other images, I need a text so it is aligned on the same row

);
};

export const getStartingPointExampleShortHeaderTitle = (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we would need a user friendly name field?

Copy link
Collaborator Author

@ClementPasteau ClementPasteau Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Maybe. The problem here is that we already have an example called "Platformer" and we want to display platformer, but the title is unique in our repo.
So maybe we could use a user-friendly title indeed.
Though, I expect all "starting-points" to be named the same way so we can manage like this

@ClementPasteau
Copy link
Collaborator Author

ClementPasteau commented Nov 25, 2024

To answer your questions

  • Why is the "Optimize for pixel art" checkbox not available on the 3 starter templates?

Discussed internally:
If we show it, we need 3 new templates as the existing assets will not work for it. Maybe something to implement afterwards if this works out well.

  • The disabled Create new game dialog action maybe gives the feeling that I can click on it if I check something. Should it not be displayed in the first screen?

Discussed internally, Removed it.

  • The top down thumbnail is not straight forward in a first glance, I thought it was a different kind of platformer

It's a hard one to represent, I'm noting down the feedback, we can update it later if needed

@ClementPasteau ClementPasteau merged commit 76eaa74 into master Nov 25, 2024
5 of 6 checks passed
@ClementPasteau ClementPasteau deleted the improve-create-game-dialog branch November 25, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants