-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Game Creation dialog #7179
Conversation
b08b39d
to
b60a944
Compare
b60a944
to
c6601ae
Compare
e4f7841
to
18f78fe
Compare
First impressions:
|
newIDE/app/src/ProjectCreation/EmptyAndStartingPointProjects.module.css
Outdated
Show resolved
Hide resolved
newIDE/app/src/ProjectCreation/EmptyAndStartingPointProjects.js
Outdated
Show resolved
Hide resolved
newIDE/app/src/ProjectCreation/EmptyAndStartingPointProjects.js
Outdated
Show resolved
Hide resolved
<Column> | ||
{isMobile && <Spacer />} | ||
<Line justifyContent="flex-start" noMargin> | ||
{/* Add a hidden text to match the height of the other tiles on the row */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the grid should normally handle that, is it really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a height: 100% is needed somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's needed, because the other elements have 2 items : image & title below.
In order to have the "empty project" element (that is inside the tile) match the other images, I need a text so it is aligned on the same row
newIDE/app/src/AssetStore/ExampleStore/ExampleInformationPage.js
Outdated
Show resolved
Hide resolved
newIDE/app/src/MainFrame/EditorContainers/HomePage/BuildSection/utils.js
Show resolved
Hide resolved
); | ||
}; | ||
|
||
export const getStartingPointExampleShortHeaderTitle = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we would need a user friendly name field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Maybe. The problem here is that we already have an example called "Platformer" and we want to display platformer, but the title is unique in our repo.
So maybe we could use a user-friendly title indeed.
Though, I expect all "starting-points" to be named the same way so we can manage like this
To answer your questions
Discussed internally:
Discussed internally, Removed it.
It's a hard one to represent, I'm noting down the feedback, we can update it later if needed |
Lots of changes including: