Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use parameters and properties in the variable action and condition #7124

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

D8H
Copy link
Collaborator

@D8H D8H commented Nov 3, 2024

Changes

  • Properties and parameters can be used in the primitive variable conditions
  • Properties can be used in the primitive variable action
  • Change the priority to:
    • Global variables
    • Scene variables
    • Properties
    • Parameters
    • Local variables

Technical solution

  • Properties and parameters are used to generate the VariablesContainersList.
    • It allows to finely choose the priority.
    • It's consistent to what is already done for the ObjectsContainerList.
  • Variable instructions uses 2 new parameter types variableOrPropertyOrParameter and variableOrProperty.
    • Instructions that use variables are references still use the parameter type variable.

TODO

  • Add tests
  • Try to find regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant