Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md link for slack-go library #2189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adlai
Copy link

@adlai adlai commented Oct 6, 2024

From the old nlopes/slack README file:

You're encouraged to update your import statements to use the official slack-go/slack version above.

It looks like the code was already updated and only this link was overlooked.

This link was overlooked when the code was updated to follow the new upstream repository.
Copy link

codeclimate bot commented Oct 6, 2024

Code Climate has analyzed commit 84f1d7e and detected 0 issues on this pull request.

View more on Code Climate.

@adlai
Copy link
Author

adlai commented Nov 17, 2024

Are the golangci-lint and test-build-upload really critical for this PR? It only modifies one link, in the human-targeted documentation. Ideally those actions would not be required for such patches, or at least would detect that the patch doesn't affect source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants