Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OverrideConfiguration #202

Conversation

marcus-talbot42
Copy link
Contributor

  • Introduced fields for values that were retrieved from the parent configuration whenever they were called.
  • Eagerly filling the new fields in the OverrideConfiguration's constructor.

Closes #201

- Introduced fields for values that were retrieved from the parent configuration whenever they were called.
- Eagerly filling the new fields in the OverrideConfiguration's constructor.
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.61%. Comparing base (14073b6) to head (1f90204).

Files Patch % Lines
...n/java/io/beanmapper/config/CoreConfiguration.java 75.00% 0 Missing and 1 partial ⚠️
...va/io/beanmapper/config/OverrideConfiguration.java 97.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
+ Coverage     87.57%   87.61%   +0.03%     
- Complexity      997      998       +1     
============================================
  Files           110      110              
  Lines          2206     2205       -1     
  Branches        247      246       -1     
============================================
  Hits           1932     1932              
- Misses          182      183       +1     
+ Partials         92       90       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcus-talbot42 marcus-talbot42 merged commit 173e59e into master Apr 4, 2024
4 checks passed
@marcus-talbot42 marcus-talbot42 deleted the improvement/Refactor-OverrideConfiguration-removing-direct-call-to-parent branch April 4, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calls from OverrideConfiguration to parentConfiguration cause unnecessary overhead.
2 participants