[#196/#197] implement caching for unproxy results #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Used to store the result BeanUnproxy#unproxy(Class)-calls. - Available as a singleton, as the results of BeanUnproxy#unproxy(Class) are deterministic, allowing the cache to be global.
- Updated logging, to prevent premature evaluation of String-formatting during performance logging.
- Updated usages of BeanUnproxy#unproxy(Class), to use UnproxyResultStore#getOrComputeUnproxyResult, which makes use of the global unproxy cache.
marcus-talbot42
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
============================================
+ Coverage 87.76% 87.80% +0.03%
- Complexity 995 998 +3
============================================
Files 109 110 +1
Lines 2199 2206 +7
Branches 248 247 -1
============================================
+ Hits 1930 1937 +7
Misses 176 176
Partials 93 93 ☔ View full report in Codecov by Sentry. |
sptdevos
reviewed
Apr 3, 2024
src/main/java/io/beanmapper/core/unproxy/UnproxyResultStore.java
Outdated
Show resolved
Hide resolved
sptdevos
reviewed
Apr 3, 2024
src/main/java/io/beanmapper/core/unproxy/UnproxyResultStore.java
Outdated
Show resolved
Hide resolved
sptdevos
reviewed
Apr 3, 2024
src/main/java/io/beanmapper/core/unproxy/UnproxyResultStore.java
Outdated
Show resolved
Hide resolved
- Made UnproxyResultStore#getInstance synchronized, for readability. - UnproxyResultStore#unproxyResultClassStore is now a ConcurrentHashMap. - Instance is no longer volatile.
sptdevos
reviewed
Apr 3, 2024
- Added BeanMapperPerformanceLogger#runTimed(Supplier, String, Object...), to allow for just-in-time formatting of log messages.
sptdevos
approved these changes
Apr 3, 2024
marcus-talbot42
deleted the
improvement/197-Implement-caching-for-Unproxy-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196 #197