Bug #190 Enum with abstract method #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
============================================
+ Coverage 87.73% 87.76% +0.03%
- Complexity 992 995 +3
============================================
Files 108 109 +1
Lines 2193 2199 +6
Branches 249 248 -1
============================================
+ Hits 1924 1930 +6
- Misses 175 176 +1
+ Partials 94 93 -1 ☔ View full report in Codecov by Sentry. |
robert-bor
force-pushed
the
bug-190-enum-with-abstract-method
branch
from
081d86b
to
a946cc5
Compare
marcus-talbot42
requested changes
Nov 9, 2023
src/test/java/io/beanmapper/testmodel/enums/WithAbstractMethod.java
Outdated
Show resolved
Hide resolved
marcus-talbot42
force-pushed
the
bug-190-enum-with-abstract-method
branch
from
6ec567a
to
3f0fc44
Compare
Since a later version of Java, when you call getCanonicalName on an enum with abstract methods, it will return a null value. This messes up several routines in BeanMapper. The method to get the canonical name has been abstracted into a utility class that can deal with the null value by calling a fallback function that looks up the canonical name of the superclass. This solves the problem at hand. All methods that directly call getCanonicalName now call the utility class instead.
marcus-talbot42
force-pushed
the
bug-190-enum-with-abstract-method
branch
from
3f0fc44
to
eaa8105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a later version of Java, when you call getCanonicalName on an enum with abstract methods, it will return a null value. This messes up several routines in BeanMapper.
The method to get the canonical name has been abstracted into a utility class that can deal with the null value by calling a fallback function that looks up the canonical name of the superclass. This solves the problem at hand.
All methods that directly call getCanonicalName now call the utility class instead.